Introduce SessionService and SessionEntityInterface. #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
added
the
architecture
aleksip
requested changes
Apr 4, 2024
module/VuFind/src/VuFind/Db/Service/SessionServiceInterface.php
Outdated
Show resolved
Hide resolved
module/VuFind/src/VuFind/Db/Service/SessionServiceInterface.php
Outdated
Show resolved
Hide resolved
module/VuFind/src/VuFind/Db/Service/SessionServiceInterface.php
Outdated
Show resolved
Hide resolved
aleksip
reviewed
Apr 4, 2024
|
Thanks for all the catches, @aleksip -- it shows that I was rushing to get this done at the end of the day; I appreciate your attention to detail. :-) I'm a little surprised that some of these things failed to trigger code style or phpstan warnings! In any case, I believe all of your suggestions have been addressed now. |
aleksip
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
@demiankatz Yes, I too was a bit surprised about that. Anyway, looks all good now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up another database entity interface and service to pave the way for #2233. It makes some minor improvements upon the current code in #2233 (e.g. renaming getBySessionId to getSessionById for consistency with existing methods like getUserById in other services); I will reconcile the differences in #2233 after this is merged.
This also adds a unit test for the SystemStatus Ajax handler, which did not previously have one.