Fix search result links losing sid when e.g. sort is changed multiple times. #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… times. saveToHistory wasn't being properly relayed when rendering the search results.
demiankatz
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Thanks, @EreMaijala, looks good to me. I'll hold off on merging until @LuomaJuha can confirm that it fully solves the problem.
Is this something we can/should have a test case for?
|
I'll see if I can add a test quickly... |
|
Test added. |
|
Gonna test this out now! |
|
Thanks, @LuomaJuha -- I'm also running @EreMaijala's new tests on this end. I expect they will pass but will report back if they don't. Otherwise, I'll just wait for your confirmation and merge this as soon as tests pass and you let me know that you're happy. :-) |
EreMaijala
added a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Apr 16, 2024
… times. (vufind-org#3589) saveToHistory wasn't being properly relayed when rendering the search results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saveToHistory wasn't being properly relayed when rendering the search results.
Continued from #3582.