Add Ratings database service. #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
commented
Apr 19, 2024
| if (is_int($resource)) { | ||
| $resource = $this->getDbTable('resource')->select(['id' => $resource])->current(); | ||
| } | ||
| return $resource->addOrUpdateRating(is_int($user) ? $user : $user->getId(), $rating); |
There was a problem hiding this comment.
I realize that addOrUpdateRating is not defined in ResourceEntityInterface. This discrepancy is only necessary as a stopgap until we get to the new code in #2233. It should be safe in the meantime.
| @@ -252,8 +252,10 @@ public function getRatingData(?int $userId = null) | |||
| // Cache data since comments list may ask for same information repeatedly: | |||
| $cacheKey = $userId ?? '-'; | |||
| if (!isset($this->ratingCache[$cacheKey])) { | |||
| $table = $this->getDbTable('Ratings'); | |||
| $this->ratingCache[$cacheKey] = $table->getForResource( | |||
| $ratingsService = $this->getDbService( | |||
There was a problem hiding this comment.
I would definitely like to decouple ratings logic from record drivers, similar to what I'd like to do for comments... but one step at a time! :-)
demiankatz
added
the
architecture
aleksip
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More backporting from #2233.