Use DbTableAwareTrait in UserService. #3632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts UserService to use DbTableAwareInterface/Trait instead of direct dependency injection and eliminates the associated custom factory. This will help eliminate circular dependencies by avoiding running the complex VuFind\Db\Row\UserFactory prematurely. After we complete the transition to Doctrine, much of this complexity will be eliminated and more explicit injection should be possible; in the meantime, though, this will make the migration easier.