Refactor AuthManager to use UserService and UserEntityInterface #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
changed the title
4 tasks
EreMaijala
requested changes
May 2, 2024
module/VuFind/src/VuFind/Auth/UserSessionPersistenceInterface.php
Outdated
Show resolved
Hide resolved
|
Thanks, @EreMaijala -- the issues you highlighted should be fixed now, and the test suite is still passing. |
EreMaijala
approved these changes
May 3, 2024
demiankatz
added
the
architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the AuthManager to use the new UserService instead of depending on the legacy Laminas table gateway. It also creates a new interface to encapsulate session persistence of user data. Right now, the UserService implements both the session and database interfaces, but these could theoretically be split apart in future.
This also adds Mink test coverage for some of the private user functionality and modernizes some of the code in the AuthManager test.