Use list items for spelling suggestions #3645
Conversation
| @@ -77,10 +77,10 @@ public function renderSpellingSuggestions($msg, $results, $view) | |||
| } | |||
|
|
|||
| $html = '<div class="' . $this->getContainerClass() . '">'; | |||
| $html .= '<h2 class="spellingSuggestions">' . $msg . '</h2>'; | |||
| $html .= '<h2 class="spellingSuggestions">' . $msg . '</h2><ul>'; | |||
There was a problem hiding this comment.
On second thought, maybe this should be an ordered <ol> since it matches the order of the search terms?
There was a problem hiding this comment.
The other question is whether the inner list of suggestions should also be a list! Because we have an outer list of input terms, and then each input term has its own independent list of suggestions. I think you could argue for ordered or unordered lists in each case as well. There is an order to both (input order for the input list, and relevance order for the output list) but it's not especially obvious and may not mean much to the end user.
There was a problem hiding this comment.
I agree -- the inner list should be a list as well.
I think I'm going to skip the ordered lists, although it's correct in some sense, it won't be obvious to the user.
|
Thanks, @maccabeelevine, this looks great to me, and the markup is definitely cleaner than before. I agree that adding the bullets makes sense. However, before I merge this, I'd like to get a second opinion. @sturkel89, do you mind checking this in all three themes and sharing an opinion? The spelling suggestions should look the same in both places, except this branch makes them a bulleted list. To easily see spelling results, I suggest: 1.) In config.ini, comment out the uncommented That should give you a couple of things to look at. |
There was a problem hiding this comment.
I reviewed the test branch in all three themes, and compared it to dev.
The bullets make it easier to see the terms for which there are spelling suggestions, and I definitely think an unordered list makes more sense than an ordered list.
The feature is pretty much identical in the three themes, so I'm only providing screenshots from sandal:
Test:
Dev:
Follow-up to #3640 to use an actual list for the "list" of suggestions, for semantics / accessibility.