Fix bug: popover broke when clicking same record in different channels. #3649
Conversation
|
@sturkel89, you should be able to reproduce the problem I described in this comment on the release-9.1 branch. This PR should fix the problem. Do you mind confirming, and also playing with this branch a little bit to see if you can find any other ways to break channels? If this is good, we should get it merged all the way through to #2934 so we can resume work on that. |
There was a problem hiding this comment.
Short story: your bug fix works as intended, and I could not break Channels in the branch!
More detail:
I was able to reproduce exactly what’s described in the comment re: the release-9.1 branch. Very weird behavior!
In the test branch, I found that the problem did not appear at all. I checked all three themes, in both desktop and mobile. I could click on the same item in multiple channels, and each time I went back and forth the popover would function correctly. All the navigation to the record or to other channels worked well, and the other features such as “show items as search results” worked well too.
Critiques: Channels on mobile
These critiques apply to release-9.1 as well as to test.
Popovers are too narrow
On mobile, the popover is a bit too narrow, and some of the text in the second column can’t be seen. The font is very small, so further shrinking on mobile would probably not be good. Is there any other way to fit this content to the screen?
Right arrows are cut off
Also, the arrow on the right is hard to see (especially in sandal and bootstrap3)"
Sandal example:
However, the tiny bit that’s visible IS clickable and functional. In any case, the arrow is not that important to most touchscreen users because it’s possible to swipe through the items in a channel on mobile; it’s not necessary to click the arrow.
This PR adds some additional data to channel items to help the popover code differentiate between instances when the same item appears in multiple channels. This fixes a bug discussed in #2934.