Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/implement CommentsServiceInterface::createEntity() #3666

Merged
merged 1 commit into from
May 20, 2024

Conversation

demiankatz
Copy link
Member

This PR adds a createEntity method for the CommentsServiceInterface for forward-compatibility with #2233. This method is not yet used in the dev branch, but it seemed worth adding for consistency with other services and to reduce diffs with the Doctrine PR.

@demiankatz demiankatz added the architecture pull requests that involve significant refactoring / architectural changes label May 16, 2024
@demiankatz demiankatz added this to the 10.0 milestone May 16, 2024
@demiankatz demiankatz removed the request for review from EreMaijala May 20, 2024 13:24
@demiankatz demiankatz merged commit 1ea184f into vufind-org:dev May 20, 2024
7 checks passed
@demiankatz demiankatz deleted the comments-create-entity branch May 20, 2024 13:24
crhallberg pushed a commit to demiankatz/vufind that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture pull requests that involve significant refactoring / architectural changes
Projects
None yet
2 participants