Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-pages: Update Jekyll #3671

Merged
merged 11 commits into from
May 22, 2024
Merged

Conversation

crhallberg
Copy link
Contributor

Jekyll was out of date enough to make standing up a dev instance difficult. These updates help enormously.

@crhallberg
Copy link
Contributor Author

crhallberg commented May 16, 2024

I see now that 025c5a3, 425e994, fa69623 are accessibility fixes. I can cherry-pick those to another branch, since I have more accessibility changes coming for the wiki.

DONE.

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crhallberg, if you don't mind cherry-picking those accessibility fixes to a separate PR, that seems like a good idea -- then if we have trouble getting these major updates to deploy correctly, we can roll them back without losing the other changes.

See below for a question about the deployment process.

Is there somewhere we can see the updated version of the webpage before we commit to deploying it? Is there a way to confirm that the updated version has successfully deployed after this gets merged?

.github/workflows/jekyll.yml Outdated Show resolved Hide resolved
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, here goes something....

@demiankatz demiankatz merged commit b2977c3 into vufind-org:gh-pages May 22, 2024
1 check passed
@demiankatz demiankatz deleted the update-v231 branch May 22, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants