Refactor favorite and user list tag unlinking. #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
added
the
architecture
demiankatz
commented
Jun 13, 2024
| $userResource->destroyLinks(null, $list->getUser()?->getId(), $list->getId()); | ||
| // Remove user_resource and resource_tags rows for favorites tags: | ||
| $listUser = $list->getUser(); | ||
| $this->resourceTagsService->destroyResourceTagsLinksForUser(null, $listUser, $list); |
There was a problem hiding this comment.
Previously the destroyLinks() method was automatically calling the tag destruction method. It seemed safer to separate these things for clarity; since we now encapsulate the functionality within FavoritesService, this seemed reasonable.
EreMaijala
requested changes
Jun 17, 2024
EreMaijala
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last significant piece of database refactoring required for the 10.0 release!
When reviewing the old tag cleanup code, I realized that it's very prone to race conditions and problems, so I simply deprecated it all. I added transactions around the "create tag and link tag to favorites" operations so that we avoid the race condition where a tag gets created and then deleted as an orphan before it can be linked up. I also inserted my recently-added orphan cleanup operation after major delete operations. I opted not to put it in the places where we delete tag lists before rewriting them, since I was concerned that might cause performance issues; I figure if we leave some orphaned tags lying around for a little while, it won't hurt, and they will get cleaned up sooner or later. We could add a command line utility to purge orphans as well if we're really worried about it.