Updated getTagList for mySQL 5.7.5+ compatibility #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated GROUP BY clause to include both tags.id and tags.tag. Fixes bug that prevents tag autocomplete when using mySQL 5.7.5+ - [ ] This is a to-do. - [x] This is a finished to-do. - [ ] Waiting to get done. - [ ] Made to-do list
|
Thanks! I've merged this in slightly modified form (put the group() parameters into an array for consistency with another group() call in the class, added a missing space for style purposes, removed to-do list from commit message). It will be included in release 3.0.1. |
olli-gold
added a commit
to tubhh/vufind
that referenced
this pull request
Aug 24, 2016
olli-gold
added a commit
to tubhh/vufind
that referenced
this pull request
Aug 24, 2016
mbeh-ub
pushed a commit
to mbeh-ub/vufind
that referenced
this pull request
Dec 16, 2016
Resolves Fehler vufind-org#713, Improvement vufind-org#701, Improvement vufind-org#712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated GROUP BY clause to include both tags.id and tags.tag. Fixes bug that prevents tag autocomplete when using mySQL 5.7.5+