Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag-Search Results #735

Closed
wants to merge 4 commits into from
Closed

Tag-Search Results #735

wants to merge 4 commits into from

Conversation

lmgonzales
Copy link
Contributor

Updates the Search Tags results page so that the searchbox has the options of the regular Search Results searchbox, thus making the search results pages (Search/Results and Tag/Home) look similar to the end user.

To Do:

  • need to make this configurable

@demiankatz
Copy link
Member

Working on integrating this revealed some potential problems with my wildcard searching implementation. I've fixed those with the help of da606e6 and eb0a07b. That allowed me to incorporate your work (with added configurability) as c6a4386. The only part of your code that I omitted was the logic to load the sort options from searches.ini. Due to the way tag sorting works, only the options hard-coded into the tag search class will work (because these are tied to MySQL database columns); loading the Solr sort options would result in database errors. If we want to add the ability to turn off some of these sort options, that could be addressed by a separate configuration option, but I don't think there's a way to fully unify sort settings due to the fact that two different underlying systems are being used.

In any case, thanks again for all of your work here. I've always felt that the tag code was a bit shabby, and you've done a good bit to make it fit more nicely into the overall system.

@demiankatz demiankatz closed this Jun 23, 2016
@lmgonzales
Copy link
Contributor Author

Thanks Demian.

mbeh-ub added a commit to mbeh-ub/vufind that referenced this pull request Dec 16, 2016
mbeh-ub added a commit to mbeh-ub/vufind that referenced this pull request Dec 16, 2016
mbeh-ub pushed a commit to mbeh-ub/vufind that referenced this pull request Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants