[VUFIND-1184] Added a method for extracting search terms for spellche… #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck queries so that extra Lucene syntax is stripped out.
|
This looks good to me! The only snag I can imagine is that there was discussion of using the full parser in the Jira ticket. Although based on your implementation, that may be overkill. I'll let Demian take a second look after his vacation this week and we'll merge next week! |
|
Manually merged to master with a couple of minor fixes and support for one more edge case: escaped quotation marks. Thanks for taking the test-driven approach here; definitely helps build confidence in the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ck queries so that extra Lucene syntax is stripped out.
I tested the ZendSearch module, but it didn't quite offer the functionality and seemed to be somewhat unmaintained with last commit from 21 Jan 2015. I also took a look at multiple Solr/Lucene components available in packagist.org, but they seem to concentrate on creating queries, understandably. So here we go with a simplistic way of parsing the search terms from the query string.