Fixed favorite deletion to not handle the form submission as a login … #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -154,7 +139,7 @@ VuFind.register('lightbox', function Lightbox() { | |||
| } | |||
| if ( // Close the lightbox after deliberate login | |||
| obj.method // is a form | |||
| && ((obj.url.match(/MyResearch/) && !obj.url.match(/Bulk/)) // that matches login/create account | |||
| && ((obj.url.match(/MyResearch/) && !obj.url.match(/Bulk/) && !obj.url.match(/Delete/)) // that matches login/create account | |||
There was a problem hiding this comment.
Does this new refresh-on-close method mean we can eliminate these hard-coded checks?
There was a problem hiding this comment.
No, those are still needed for the login event to fire, and if you'd like to get rid of the automatic refresh on login, any login form displayed in the lightbox would need to have data-lightbox-close="VuFind.refreshPage();" or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…event.
Deleting favorites refreshed the page only because the lightbox thought it was a login event. While I'd like to have a more robust mechanism for detecting login form submission, this change prevents MyResearch/Delete action from being handled as a login event. Subsequently a page refresh is required after deletion, so I moved the refreshPage method to VuFind common, used it in the deletion form and made the lightbox also use it.
I also moved the h2 of the delete screen to a more proper place before the form. While this doesn't make a difference in bootstrap3 or bootprint3, it's in line with other pages and makes it easier to customize in CSS how headings are displayed in the lightbox.