Fix order of modal show and ajax request to avoid the possibility of … #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calling handleUpdate for the modal before it's actually shown.
|
See also #835. |
|
I'm going to confirm that the Lightbox shows a Loading... text before recommending this for a merge. |
|
Yes, I see no problems with this change. Demian, if you want to run the test suite to be sure please do then merge, but I don't see how this could cause problems, just increase stability. Thank you, Ere! |
|
All tests pass -- thanks, everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…calling handleUpdate for the modal before it's actually shown.