Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel provider for AlphaBrowse index #975

Merged
merged 12 commits into from Jul 20, 2017
Merged

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented May 24, 2017

This PR adds a new channel provider to find nearby records in the alphabrowse index; most useful for displaying "nearby on shelf" information.

TODO

  • Get thumbnail images working
  • Consider hiding the "seed" record from the browse list Leaving it in place for now; provides some useful context.
  • Eliminate unnecessary code copied from SimilarItems provider (used as foundation for this)
  • Make sure all labels and cross-links are appropriate for the context; add new translation strings if necessary
  • Test that all configuration settings work properly (LCC vs. Dewey, etc., etc.)
  • Make sure channel tokens work in a sensible way
  • Consider an "infinite scrolling" mechanism to allow the browse to continue indefinitely in both directions Could be useful, but that significantly broadens the scope of this PR; can consider later.
  • Test that functionality behaves correctly when no valid call number is found
  • Improve handling of adding empty channels (currently it causes an empty channel to appear -- it might be better to handle this in a different way; note that this may be a more general problem that needs to be fixed in master independently of this PR).

@demiankatz demiankatz removed the request for review from crhallberg July 20, 2017 18:48
@demiankatz demiankatz merged commit a382b13 into master Jul 20, 2017
@demiankatz demiankatz deleted the alphabrowse_channel branch September 14, 2017 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant