Up-to-date tinygo support #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmt.Print relies on a deferred recover() to catch nil pointer dereferences in String() calls. Tinygo does not support this at the moment, so we need to explicitly handle it in the String() method.
Since the original tinygo support was implemented, tinygo has evolved a lot. It now supports modules, so we don't need to fiddle around with temporary build directories and explicit "go get" calls, etc. This patch also changes the default docker image to tinygo/tinygo:0.22.0 which now works perfectly well for vugu's needs.
Changing the tests in wasm-test-suite to perform the build with and without docker. Also enabled some tests that did not work with tinygo in the past.
This makes it easier to see where it's failing in the test output
They failed with Go 1.17 Github Actions, but I don't know if that's because they didn't quite finish or if something actually got stuck. The Go 1.16 run finished in 8m24, so if we reach 20 minutes, it's almost certainly because something got stuck. Let's see.
|
hey @sorenisanerd @bradleypeabody i use tnygo and so can help out if needed... Wondering what's he status with this ? |
|
Sorry this didn't get its due attention. Overall this looks good. Is there any context on the check in vgnode.go to see if Indirect() worked in - is this fixing something specific? Otherwise I will see if I can run all this at some point hopefully today and help verify and then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the original tinygo support was implemented, tinygo has evolved
a lot. It now supports modules, so we don't need to fiddle around with
temporary build directories and explicit "go get" calls, etc.
This patch also changes the default docker image to
tinygo/tinygo:0.22.0 which now works perfectly well for vugu's needs.