-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Greisen Profile #15
base: master
Are you sure you want to change the base?
Conversation
'Scaled_ellipsoide'. The shape depends only on energy of primary photon and height of first interaction.
Shower z axis distribution now determined by Greisen function.
Update to include Greisen Function
Hi @CDYMoore and thank you very much for your contribution. First question, have you merged the last master version of pschitt in your version? If not, please do. About the code:
Example to avoid loops:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes (see comments in discussion)
I now better understand the need for the scaling factor. However, I would suggest to remove it and have a number of particles = min(shower.number_of_particles, physical_number_of_particles) and explain this in the docstring of the |
Griesen profile added to sky_objects.py allowing for random distribution of particles along Z axis with a distribution dependent on the initial energy and interaction height of the shower.
X and Y profiles set by random Gaussian distributions scaled such that on average 90% of particles reside within 1 Moliere Radius of the shower axis (at sea level).
If shower = pschitt.sky_objects.shower:
-> Simulation using Greisen Function activated with "shower.Greisen_Profile()"
-> New shower input parameters needed in run script:
--> "shower.energy_primary = number[eV]" : sets energy of the primary gamma-ray photon.
--> "shower.height_of_first_interaction = height[m]" : sets the height at which the initial photon interacts with the atmosphere.
--> "shower.scale = number[-]" : sets the resolution of the distribution function produced from the Greisen Function. A lower number corresponds to a higher number of simulated particles. (Recommended range: 1-100).
Inputs no longer needed in run script:
-> "shower.number_of_particles" : determined by primary energy.
-> "shower_top/length/width : determined by preprogrammed functions (see top of comment).