Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add nvim-notify support #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agoodshort
Copy link

@agoodshort agoodshort commented Oct 5, 2023

As the title says, this adds support for nvim-notify.

The idea so far is to check if nvim-notify is installed, and if it is, we use vim.notify() to display the loading status.

I'm not sure how most people use nvim-notify and if they hook vim.notify = require("notify") as described in the README.
I personally use it through noice and this implementation works as expected. Maybe someone from #131 can shime in.

Next steps/questions:

  • Update docs?
  • Should it be configurable?
recording_20231005-234247.webm

(Kinda cool I received an error message during my recording 馃ゲ)


Credit to this snippet which helped a lot to understand how to replace an existing notification


Closes #131

@agoodshort agoodshort changed the title Add nvim-notify support Feat: Add nvim-notify support Oct 5, 2023
@vuki656
Copy link
Owner

vuki656 commented Oct 6, 2023

Looks good. Thanks for implementing it.

As for the configurability, maybe see it people want it and add it then, not sure. Up to you :D


As for the error, I saw it happens and not sure why. I don't use the plugin myself that much so I haven't prioritized fixing it. If you are up for it, I'd be glad to help.


As for the docs, maybe add a note somewhere that notify is supported and put this video. I think that would work. Maybe without the error :D

@agoodshort
Copy link
Author

I am gone on holidays, will be back on a PC towards the end of October. I will then work on the points above.
Hope we get some feedback from people by then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Support nvim-notify
2 participants