Buffer ReverseProxy use http.ReverseProxy #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
force-pushed
the
x-forwarded
branch
2 times, most recently
from
5256d53
to
bca0383
Compare
juliens
force-pushed
the
x-forwarded
branch
2 times, most recently
from
3522cc7
to
e0f897f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merge serveBufferHTTP and serveStreamHTTP to both use the http.ReverseProxy (as http.ReverseProxy without flushInterval works in "buffer" mode)
We fix XForwarded too because some parts are already in http.ReverseProxy
http.ReverseProxy don't have
ErrorHandling, that's why I have wrote a PR on go.In the meantime, I have proxied the RoundTripper in order to catch the errors.
With this, there is a little breaking change, in the ErrorHandler.serveHTTP, you can not Hijack/Flush anymore.