Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from go-check to Testify. #146

Merged
merged 1 commit into from Jul 9, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 7, 2018

Migrate from go-check to Testify, because:

  • go-check is not really maintained
  • go-check have several bugs
  • Testify allow to return parallel tests

@ldez ldez force-pushed the refator/gocheck-to-testify branch 3 times, most recently from c4c3d2a to 8aad2e0 Compare July 9, 2018 13:14
@ldez ldez force-pushed the refator/gocheck-to-testify branch from 8aad2e0 to 771c748 Compare July 9, 2018 13:17
Copy link
Contributor

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilevauge emilevauge merged commit f0cbb9d into vulcand:master Jul 9, 2018
@ldez ldez deleted the refator/gocheck-to-testify branch July 9, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants