Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(buffer): Support gRPC and gRPC Web #236

Merged
merged 1 commit into from
Apr 17, 2023
Merged

feat(buffer): Support gRPC and gRPC Web #236

merged 1 commit into from
Apr 17, 2023

Conversation

longit644
Copy link
Contributor

Since gRPC is a POST request, the response does not include Content-Length header and the status of gRPC response is returned through Grpc-Status header instead of using HTTP status, so HTTP status is alway 200. As a result, the expectBody always returns true. However when an error is returned from an upstream gRPC server, the response body is empty and the buffer middleware will work incorrectly.

@longit644 longit644 changed the title Support gRPC and gRPC Web in "buffer" middleware feat(buffer): Support gRPC and gRPC Web Apr 17, 2023
ldez
ldez approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 03de175 into vulcand:master Apr 17, 2023
@longit644 longit644 deleted the feat/support-buffer-grpc branch April 18, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@longit644 @ldez