Fix race condition #34

[kevioke]

Fix race condition #34

[kevioke]

@klizhentas can you help me with this PR?

[klizhentas]

I think there's a potential deadlock here:

a.Append(b)

and

b.Append(a)

will deadlock.

To mitigate the issue, I would suggest to do the following:

1. implement Export function that uses RLock and returns the copy of the map with status codes
2. in append, do this:

copied := other.Export()
m.Lock()
defer m.Unlock()
do the merge....
return 

[kevioke]

Good catch! I'll update this.

[klizhentas]

done, sorry for the delay. two notes:

1. about possible deadlock (see above)
2. general thought - why not guard histogram as well and not just status codes?

Thanks

[kevioke]

Hi @klizhentas, sorry for the delay I was busy with some other work. I've update the PR for the two points you've mentioned.

Let me know if I missed anything. Happy to make changes.

[ldez]

any news on this PR?