Allow LogFormatter to be set from service options #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for custom logrus formatters. If this property is set, vulcan will use this value when calling log.SetFormatter; otherwise, the default behavior (using the Options.Log string to determine the logrus formatter) will be used.
…ernally. Merge ../../chanaoka/vulcand into archis/dev
Taking over and building up on this PR: #307 I made sure that the log formatter is always set without erroring out, even if syslog, or any other formatter fails to work.
klizhentas
approved these changes
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building on this PR:
#307
And making the suggested modification by @klizhentas.