This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Use marshall binary for receipts and txns. #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-norden
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
As part of #84 we need to eventually remove any dependency of ipld-eth-server on this repo (and deprecate this repo), so the receipt and tx ipld methods updated here could instead be imported from v1.10.5-statediff-0.0.25 vulcanize geth (where they are already using UnmarshalBinary/MarshalBinary).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs to be merged since this is blocked by it.