(VDB-366) Add sin mapping to vow storage transformer #51
Conversation
| if err != nil { | ||
| return nil, err | ||
| } | ||
| encodedBytes := hexutil.EncodeUint64(uint64(intTimestamp)) |
There was a problem hiding this comment.
This hex stuff is just the first way I found to convert an int to a byte array, not sure if there's a clearer or more idiomatic way of going about it.
There was a problem hiding this comment.
Could you also do something like this: []byte(timestamp) to convert the timestamp string into a byte array?
There was a problem hiding this comment.
Weirdly no, that doesn't work (I get a different array)... so I guess my initial comment was wrong, I must not just be converting an int to a byte array. I'm gonna dig in a little bit and figure out exactly what's happening in this function
| @@ -43,11 +43,15 @@ var FakeHeader = core.Header{ | |||
| } | |||
|
|
|||
| func GetFakeHeader(blockNumber int64) core.Header { | |||
| return GetFakeHeaderWithTimestamp(fakeTimestamp, blockNumber) | |||
There was a problem hiding this comment.
I haven't made this change in vulcanizedb yet, it's part of a PR I'm about to open
this change is now a very small PR in vulcanizedb. I'll copy-paste it into vendors before merging
It's merged in now
Gslaughl
requested review from
rmulhol,
m0ar,
i-norden,
elizabethengelman and
yaoandrew
Gslaughl
force-pushed
the
vdb-366-vow-storage-update
branch
5 times, most recently
from
752f9cc
to
466422e
Compare
A couple of small questions, that aren't merge blocking.| db.MustExec("DELETE FROM maker.vow_sin_integer") | ||
| db.MustExec("DELETE FROM maker.vow_sump") | ||
| db.MustExec("DELETE FROM maker.vow_vat") | ||
| db.MustExec("DELETE FROM maker.vow_wait") |
| if err != nil { | ||
| return nil, err | ||
| } | ||
| encodedBytes := hexutil.EncodeUint64(uint64(intTimestamp)) |
There was a problem hiding this comment.
Could you also do something like this: []byte(timestamp) to convert the timestamp string into a byte array?
transformers/storage/vow/mappings.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func getSinKey(timestamp string) common.Hash { |
There was a problem hiding this comment.
Is this string the hex representation of the timestamp? I wonder if it would be helpful to specify that in the var name, like hexTimestamp or something?
Gslaughl
force-pushed
the
vdb-366-vow-storage-update
branch
from
466422e
to
3ef1f49
Compare
I think this is just about right. Still have a couple questions though