Move changelog and diagram information to contributing.md #98
Conversation
elizabethengelman
requested review from
i-norden,
rmulhol,
yaoandrew,
Gslaughl and
m0ar
documentation/contributing.md
Outdated
| 1. Go to [draw.io](draw.io). | ||
| 1. Click on *File > Open from* and choose the location of the diagram you want to update. | ||
| 1. Once open in draw.io, you may update it. | ||
| 1. Export the diagram to this repository's directory and add commit it. |
There was a problem hiding this comment.
How does this work if it's stored as a .png in the project? 🤔
There was a problem hiding this comment.
Do you mean like how are we able to update it one it's already been saved as a .png file? That's a great question, and I'm actually not sure! I'd be interested to see if someone else could give it a whirl to see if it works for others, and not just a works on my machine thing.
There was a problem hiding this comment.
I'm not sure I follow - if you replaced the existing .png in the project with another one and committed, I would expect that to be reflected as a change to the repo, no?
There was a problem hiding this comment.
@rmulhol I mean, if you open a .png in draw.io, is it editable?
There was a problem hiding this comment.
Yeah, for me it is editable when I open it in draw.io. Would someone else be able to give it a try too? Just to make sure it's not just editable for me because I created it.
There was a problem hiding this comment.
Huh, awesome! Should be cool then 👌
documentation/contributing.md
Outdated
| 1. Go to [draw.io](draw.io). | ||
| 1. Click on *File > Open from* and choose the location of the diagram you want to update. | ||
| 1. Once open in draw.io, you may update it. | ||
| 1. Export the diagram to this repository's directory and add commit it. |
elizabethengelman
force-pushed
the
additional-doc-updates
branch
2 times, most recently
from
ea890b4
to
7804007
Compare
elizabethengelman
force-pushed
the
additional-doc-updates
branch
from
7804007
to
5088574
Compare
Thought it maybe made more sense for these "repo maintenance" things to be in the contributing doc, but am not super attached to this change.