-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge some translations from GlitchWitchIO/vulhub-en #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
README.md
Outdated
@@ -1,11 +1,11 @@ | |||
# Vulhub - Docker-Compose files for vulnerabilities environment | |||
# Vulhub - Docker-Compose files for creating vulnerable environments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about
Vulhub - pre-built vulnerable environments based on Docker-Compose
and also
Vulhub is an open-source collection of pre-built vulnerable environments based on Docker-Compose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between "collection of" and "set of" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Vulhub - pre-built vulnerable environments based on Docker-Compose
would be a good change. 👍
collection of
sounds more accurate/professional than set of
so I am up for changing that too!
However I think the final sentence should look like this
Vulhub is an open-source collection of pre-built vulnerable docker environments
I can push a commit with these changes if you both think that's okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Now it's up to @phith0n to merge.
@glitchwitchio |
@phith0n Thanks for the positive feedback. You can certainly invite me 😃 |
Merge some translations from GlitchWitchIO/vulhub-en as per #40