Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge some translations from GlitchWitchIO/vulhub-en #59

Merged
merged 7 commits into from
Sep 6, 2018

Conversation

GlitchWitch
Copy link
Member

@GlitchWitch GlitchWitch commented Sep 4, 2018

Merge some translations from GlitchWitchIO/vulhub-en as per #40

@GlitchWitch GlitchWitch changed the title Updated english readme. Fixed some grammar. Merge some translations from GlitchWitchIO/vulhub-en Sep 4, 2018
Copy link
Member

@phith0n phith0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

README.md Outdated
@@ -1,11 +1,11 @@
# Vulhub - Docker-Compose files for vulnerabilities environment
# Vulhub - Docker-Compose files for creating vulnerable environments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phith0n @glitchwitchio

What about

Vulhub - pre-built vulnerable environments based on Docker-Compose

and also

Vulhub is an open-source collection of pre-built vulnerable environments based on Docker-Compose

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between "collection of" and "set of" ?

Copy link
Member Author

@GlitchWitch GlitchWitch Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Vulhub - pre-built vulnerable environments based on Docker-Compose would be a good change. 👍

collection of sounds more accurate/professional than set of so I am up for changing that too!

However I think the final sentence should look like this
Vulhub is an open-source collection of pre-built vulnerable docker environments

I can push a commit with these changes if you both think that's okay.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfdye
I pushed the commit feea950 with the changes discussed above. Please let me know what you think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Now it's up to @phith0n to merge.

@phith0n
Copy link
Member

phith0n commented Sep 5, 2018

@glitchwitchio
May I invite you for joining our organization ?

@GlitchWitch
Copy link
Member Author

@phith0n Thanks for the positive feedback. You can certainly invite me 😃

@phith0n phith0n merged commit 4a4c6a0 into vulhub:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants