Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to avoid merge conflicts in the changelog? #1590

Closed
Rua opened this issue May 23, 2021 · 4 comments
Closed

Any way to avoid merge conflicts in the changelog? #1590

Rua opened this issue May 23, 2021 · 4 comments

Comments

@Rua
Copy link
Contributor

Rua commented May 23, 2021

As I'm sure @Eliah-Lakhin and others have noticed, most merge conflicts happen in the CHANGELOG_VULKANO.md file. This presumably happens because every PR modifies it, and all the changes are concentrated in the same area of the file. It would be nice if not every PR had merge conflicts, that need to be fixed, only to reappear as soon as another PR is merged before it.

I don't know much about Github's features, but I believe it may have something to handle changelogs for Vulkano? Or perhaps there's a way to handle the current file so that there's no conflicts. Any ideas?

@Eliah-Lakhin
Copy link
Contributor

Eliah-Lakhin commented May 23, 2021

@Rua Yes, I completely agree. The changelog is something that is the most annoying factor involved in review process. I don't know how to properly enforce changelog conflicts autoresolving, but I think I can change the Pull Request template requirements to ask people to put incoming changelog changes into the PR description itself, instead of the actual changes in the changelog. Then, after the PR merge, I will transfer each entry myself manually. What do you think?

@Rua
Copy link
Contributor Author

Rua commented May 23, 2021

I was thinking of that as well. As long as you are up to editing the changelog yourself, I think that's workable.

@Eliah-Lakhin
Copy link
Contributor

@Rua ok, I will change the requirements starting from the next week.

@Eliah-Lakhin
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants