fix for android surface acquiring #1868
Conversation
| use winit::platform::android::WindowExtAndroid; | ||
|
|
||
| Surface::from_android(instance, win.borrow().native_window(), win) | ||
| use raw_window_handle::HasRawWindowHandle; |
There was a problem hiding this comment.
raw_window_handle is behind a feature gate in Cargo.toml. It's enabled by default, but if the user decides to disable it and use only the winit feature, this code won't work anymore.
There was a problem hiding this comment.
interesting, the reason I chose this solution is because the other one was silently deprecated. This seams to be the way, the developer intended for this to work. I don't know how to fix this properly, maybe require the feature for android?
There was a problem hiding this comment.
Since they suggested always using raw_window_handle (on any platform), I think removing optional = true from the dependency and having it always there makes the most sense. Then the code in winit.rs can use this for all platforms instead of Winit's various custom traits like WindowExtUnix and WindowExtWindows. It's a bit more of a change so if you want to do it only for Android that's fine, I can do it for the other platforms later.
There was a problem hiding this comment.
I dont know why it is optional, maybe they have their reasons. On this end we could probably add the requirement in the README so everyone knows that the feature is required. I don't have access to all the platforms to properly test a change like that. I could do it for windows.
|
I've merged it, and will look at the things I mentioned myself sometime. Thank you for the fix! |
fixes issue#1417
Fix for android surface acquiring.cargo fmton the changes.cargo fmtseams to have sorted some imports in vulkano/src/command_buffer/mod.rsMake sure that the changes are covered by unit-tests.
Update documentation to reflect any user-facing changes - in this repository.