Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raytracing shaders with vulkano-shaders #1888

Merged
merged 3 commits into from May 2, 2022
Merged

Conversation

Atilogit
Copy link
Contributor

@Atilogit Atilogit commented May 2, 2022

This PR adds functionality to compile raytracing shaders.
This was part of a project to add partial raytracing support to vulkano but i didn't get around to finishing it.

The code in vulkano/src/shader/reflect.rs is only a workaround. I didn't have the time to get far enough to do it properly.

* Entries for Vulkano changelog:
    - vulkano-shaders now supports `raygen`, `anyhit`, `closesthit`, `miss`, `intersection` and `callable` shaders

@Rua
Copy link
Contributor

Rua commented May 2, 2022

Looks good, thank you! For future reference, the workaround in reflect.rs, what should actually be done there?

@Atilogit
Copy link
Contributor Author

Atilogit commented May 2, 2022

Not sure. I didn't spend much time with the reflection part of vulkano

@Rua Rua merged commit 31a2033 into vulkano-rs:master May 2, 2022
Rua added a commit that referenced this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants