Image extent zero length #1893
Merged
Image extent zero length #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was initially set to resolve issue #1892 for all examples. Namely, the goal was to ensure the examples did not crash when minimized. The cause of the crashes is that Windows sets the surface size to zero by zero when minimized. Coincidentally, the swapchain creation code was incorrectly validating VUID-VkSwapchainCreateInfoKHR-imageExtent-01689 by asserting that at least one dimension was non-zero.
SwapchainCreationError ::ImageExtentZeroLengthDimensionsto be returned when at least one of the image extent's dimensions are zero.