Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dynamic state commands #1911

Merged
merged 1 commit into from Jun 6, 2022
Merged

Refactor dynamic state commands #1911

merged 1 commit into from Jun 6, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jun 6, 2022

Changelog:

- **Breaking** The `set_depth_bounds` parameter is now a single `RangeInclusive` instead of two separate `f32`, to match the type used on the `DepthBoundsState` struct.

Mostly mechanical work in this one, and one breaking change.

AustinJ235
AustinJ235 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AustinJ235 AustinJ235 merged commit 6da73f3 into vulkano-rs:master Jun 6, 2022
AustinJ235 added a commit that referenced this pull request Jun 6, 2022
@AustinJ235
#1911 Changelog Update
3ae9ec0
@Rua Rua deleted the refactor-dynamic branch September 17, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinJ235 AustinJ235 AustinJ235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rua @AustinJ235