Merged ImmutableBuffer into DeviceLocalBuffer #1934
#1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rua
reviewed
Jul 31, 2022
vulkano/src/buffer/device_local.rs
Outdated
| where | ||
| T: BufferContents + ?Sized, | ||
| { | ||
| /// Builds an `ImmutableBuffer` that copies its data from another buffer. |
There was a problem hiding this comment.
The documentation needs to be updated here.
|
It all looks good, thanks for the help! |
|
Thank you! Glad to have helped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't much practical difference between these two types anymore, since the 0.30 release.
CHANGELOG entry:
ImmutableBuffermerged intoDeviceLocalBuffer.Closes #1934.