Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkano-shaders struct generation refactor #1945

Merged
merged 1 commit into from Aug 7, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Aug 6, 2022

Changelog:

- Bugs fixed:
  - [#1896](https://github.com/vulkano-rs/vulkano/issues/1896): Vulkano-shaders generates invalid struct definitions when struct field names are stripped out by the compiler.

This refactors the code in Vulkano-shaders that generates struct definitions for Rust, to make it easier to read. It also fixes #1896. There are still some problems with the current code, including #1208 and #1530.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use precompiled shader with optimization
2 participants