Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libloading instead of shared_library #1947

Merged
merged 1 commit into from Aug 8, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Aug 7, 2022

Changelog (add to existing headers):

- **Breaking** Changes to `Instance` and Vulkan initialization:
  - `VulkanLibrary::get_instance_proc_addr` is now `unsafe`, and returns `ash::vk::PFN_vkVoidFunction`.

This replaces the shared_library crate with libloading. The original library was created by Tomaka, but has not been maintained since. The replacement crate is more up to date and much more widely used.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AustinJ235 AustinJ235 merged commit f465775 into vulkano-rs:master Aug 8, 2022
AustinJ235 added a commit that referenced this pull request Aug 8, 2022
@Rua Rua deleted the libloading branch September 17, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants