Make PhysicalDevice
an independent object
#1967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1966.
Changelog:
This is based on a request that was made on the Vulkano discord. It doesn't make sense to keep the physical device data in the instance permanently, because devices can be added or removed while the program is running. So now, they are retrieved fresh each time you enumerate.
The changes to
MemoryType
,MemoryHeap
andQueueFamily
are made to bring the API a bit closer to Vulkan. While these types did add a layer of type system-level safety, they were also a bit cumbersome to use, and couldn't be stored anywhere because they had a lifetime parameter. So most of the time, you'd end up storing an index anyway.