Fix "expected expression, found ,
" compile error for precompiled shaders with more than one entrypoint
#2136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c6959aa seems to have introduced a regression that causes the vulkano-shaders macro to emit two consecutive commas for any single shader module with more than one entry point. (Since vulkano-shaders doesn't generate shader modules with multiple entrypoints itself as far as I know, this regression only manifests on precompiled shaders in practice.)
Here's a minimal reproducible example with two entrypoints
vert
andfrag
: shaders.spv.zipDumping the generated macro output reveals the double comma of doom:
Luckily, the fix for this is to simply remove the offending comma from the
write_entry_point
method - a one character change that makes this PR quite possibly the shortest PR I've ever authored :DChangelog: