Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationError-ify command buffers and command pools #2254

Merged
merged 1 commit into from Jul 6, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jul 6, 2023

Changelog:

Changes to command buffers:
- `CommandPoolResetError` is renamed to `ResetCommandPoolError`.
- Command pool creation and resetting now take `CommandPoolCreateFlags` and `CommandPoolResetFlags` respectively.

Just the usual. The renaming of the error type follows the guidelines here: https://rust-lang.github.io/api-guidelines/naming.html#names-use-a-consistent-word-order-c-word-order

@marc0246
Copy link
Contributor

marc0246 commented Jul 6, 2023

Can we determine once and for all what convention for naming errors to use? Right now we have the forms (using random error name as an example) BufferAllocateError, BufferAllocationCreationError, BufferError as well as now AllocateBufferError.

@marc0246 marc0246 merged commit cf46928 into vulkano-rs:master Jul 6, 2023
3 checks passed
marc0246 added a commit that referenced this pull request Jul 6, 2023
@Rua Rua deleted the cb-validation branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants