Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for VkExportMemoryAllocateInfo #2258

Merged
merged 2 commits into from Jul 10, 2023
Merged

Add validation for VkExportMemoryAllocateInfo #2258

merged 2 commits into from Jul 10, 2023

Conversation

marc0246
Copy link
Contributor

@marc0246 marc0246 commented Jul 9, 2023

Changelog:

### Breaking changes
- `ExternalBufferInfo::sparse` was replaced by a `flags` field.

### Bugs fixed
- Added missing validation for `MemoryAllocateInfo::export_handle_types`.

I'm unsure whether this belongs in Bugs fixed or Additions, since we knew this validation wasn't present.

@Rua
Copy link
Contributor

Rua commented Jul 10, 2023

I don't think we need to report the addition of validation in the changelog, unless it causes breaking changes.

@Rua
Copy link
Contributor

Rua commented Jul 10, 2023

Looks good, thanks!

@Rua Rua merged commit c0bc610 into vulkano-rs:master Jul 10, 2023
3 checks passed
@marc0246 marc0246 deleted the export-handle-types-validation branch July 10, 2023 10:37
Rua added a commit that referenced this pull request Jul 10, 2023
@Rua
#2258 changelog
1350d69
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
Add validation for VkExportMemoryAllocateInfo (vulkano-rs#2258)
89310fd 
* Add validation for `VkExportMemoryAllocateInfo`

* Fix oopsie
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
vulkano-rs#2258 changelog
990682f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marc0246 @Rua