Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidationError-ify sync primitives #2267

Merged
merged 4 commits into from Jul 24, 2023
Merged

ValidationError-ify sync primitives #2267

merged 4 commits into from Jul 24, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jul 22, 2023 •
edited

Changelog:

### Breaking changes
Changes to synchronization primitives:
- `Event::signaled` is renamed to `is_signaled`, to match the method on `Fence`.
- The `set_raw` and `reset_raw` methods of `Event` are removed.
- `Event::reset` is now `unsafe`, as it has preconditions that cannot be validated.
- `FenceCreateInfo::signaled` is replaced with a `flags` field.

@Rua Rua mentioned this pull request Jul 24, 2023
Merged
@marc0246 marc0246 merged commit 4d9288b into vulkano-rs:master Jul 24, 2023
3 checks passed
marc0246 added a commit that referenced this pull request Jul 24, 2023
@marc0246
#2267 changelog
69a0a7a
@Rua Rua deleted the sync-primitive-validation branch October 25, 2023 14:24
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
ValidationError-ify sync primitives (vulkano-rs#2267)
77a0b28 
* ValidationError-ify sync primitives

* Fix Windows error

* Return timeouts as errors instead

* Simplify a bit
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
vulkano-rs#2267 changelog
d9c1efa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rua @marc0246