Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the hex-encoded public key of the issuer is missing IssuanceContract struct #182

Closed
tiero opened this issue Nov 22, 2021 · 4 comments · Fixed by #183
Closed

the hex-encoded public key of the issuer is missing IssuanceContract struct #182

tiero opened this issue Nov 22, 2021 · 4 comments · Fixed by #183
Assignees
Labels
bug Something isn't working

Comments

@tiero
Copy link
Member

tiero commented Nov 22, 2021

Here we should include the Issuer Pub Key as weel

reference specification

https://docs.blockstream.com/liquid/developer-guide/proof-of-issuance.html#contract-json-fields

@tiero tiero added the bug Something isn't working label Nov 22, 2021
@tiero tiero changed the title IssuanceContract is missing issuer pubkey the hex-encoded public key of the issuer is missing IssuanceContract struct Nov 22, 2021
@tiero
Copy link
Member Author

tiero commented Nov 22, 2021

Test need to be updated and keys must be sorted lexographically to produce right contract hash @sekulicd

https://docs.blockstream.com/liquid/developer-guide/proof-of-issuance.html#contract-hash

@sekulicd
Copy link
Collaborator

As per doc, json sorts key lexographically by default, as for the tests need to check with pietro on how fixtures were generated since there were no pubkey

@sekulicd
Copy link
Collaborator

As per doc, json sorts key lexographically by default, as for the tests need to check with pietro on how fixtures were generated since there were no pubkey

Actually this is not true as only maps are sorted and not structs.
@tiero

@tiero
Copy link
Member Author

tiero commented Nov 23, 2021

json sorts key lexographically

good to know, thanks

how fixtures were generated

I guess they have been generated manually.

You can use POST /contract/validate to add test for the contract hash

ie.

{"version":0,"issuer_pubkey":"02a9a7399de89ec2e7de876bbe0b512f78f13d5d0a3315047e5b14109c8bac38f2","name":"Tiero Token","ticker":"TIERO","entity":{"domain":"tiero.github.io"},"precision":0}

Expected hash

cc64512512e0bc75ff028115bb6c466393dc91f257e3f883a58154b34dbca836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants