Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance: add create by snapshot #56

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Conversation

resmo
Copy link
Collaborator

@resmo resmo commented Jan 20, 2023

Description

add option to create instance by snapshot

Related Issues

closes #55

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Base: 92.01% // Head: 64.67% // Decreases project coverage by -27.34% ⚠️

Coverage data is based on head (f4744c4) compared to base (5ed7df2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #56       +/-   ##
===========================================
- Coverage   92.01%   64.67%   -27.34%     
===========================================
  Files          25        3       -22     
  Lines         751      402      -349     
  Branches      118       56       -62     
===========================================
- Hits          691      260      -431     
- Misses         23      141      +118     
+ Partials       37        1       -36     
Impacted Files Coverage Δ
...tions/vultr/cloud/plugins/module_utils/vultr_v2.py 18.78% <0.00%> (-73.34%) ⬇️
...vultr/cloud/plugins/modules/startup_script_info.py
...ctions/vultr/cloud/plugins/modules/account_info.py
...lections/vultr/cloud/plugins/modules/dns_domain.py
...ons/vultr/cloud/plugins/modules/plan_metal_info.py
...ctions/vultr/cloud/plugins/modules/ssh_key_info.py
...ble_collections/vultr/cloud/plugins/modules/vpc.py
...ions/vultr/cloud/plugins/modules/firewall_group.py
...tions/vultr/cloud/plugins/modules/block_storage.py
...tions/vultr/cloud/plugins/modules/firewall_rule.py
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@resmo resmo force-pushed the feature/instance_by_snapshot branch from 36fb9be to f4744c4 Compare January 20, 2023 18:01
@resmo
Copy link
Collaborator Author

resmo commented Jan 20, 2023

successfully tested using a manual uploaded snapshot (raw image), once the snapshot module is ready, I'll extend the tests case.

@resmo resmo merged commit d9664e8 into main Jan 20, 2023
@resmo resmo deleted the feature/instance_by_snapshot branch January 20, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Add support for creating instances from a Snapshot
3 participants