Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewall_rule: ignore port if not tcp/udp but warn #77

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

resmo
Copy link
Collaborator

@resmo resmo commented Jun 26, 2023

Description

Fix idempotency if port is set but protocol is not tcp/udp. Also see https://www.vultr.com/api/#operation/post-firewalls-firewall-group-id-rules

Related Issues

Fixes #76

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@resmo resmo changed the title firewall_rule: ignore port if not tcp/upd but warn firewall_rule: ignore port if not tcp/udp but warn Jun 26, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -27.26 ⚠️

Comparison is base (9527494) 91.64% compared to head (5704842) 64.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #77       +/-   ##
===========================================
- Coverage   91.64%   64.39%   -27.26%     
===========================================
  Files          27        3       -24     
  Lines         814      410      -404     
  Branches      130       59       -71     
===========================================
- Hits          746      264      -482     
- Misses         28      145      +117     
+ Partials       40        1       -39     

see 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@resmo resmo added the automation Trigger intergration tests label Jun 26, 2023
@resmo resmo added automation Trigger intergration tests and removed automation Trigger intergration tests labels Jun 26, 2023
@resmo resmo merged commit b53b7fe into main Jun 26, 2023
5 checks passed
@resmo resmo deleted the fix/firewall_rule-ignore_port_warn branch June 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Trigger intergration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Idempotence check fails in vultr.cloud.firewall_rule when ICMP has port
2 participants