Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rancher machine #25

Merged
merged 9 commits into from
Jun 27, 2023
Merged

Rancher machine #25

merged 9 commits into from
Jun 27, 2023

Conversation

happytreees
Copy link
Contributor

Description

This PR will update the docker-machine to use up-to-date dependencies, and refactor the code

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@happytreees happytreees added the enhancement New feature or request label Jun 22, 2023
@happytreees happytreees self-assigned this Jun 22, 2023
@happytreees happytreees marked this pull request as ready for review June 23, 2023 16:30
@@ -260,8 +231,8 @@ func (d *VultrDriver) SetConfigFromFlags(opts drivers.DriverOptions) error {
}

// NewDriver ... instanciate new driver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo: instantiate

@optik-aper
Copy link
Member

A couple lint issues:

machine/driver/driver.go:253:33: Error return value of `d.addSSHKeyToCloudInitUserData` is not checked (errcheck)
		d.addSSHKeyToCloudInitUserData()
		                              ^
machine/driver/helper.go:97:24: stringintconv: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?) (govet)
	dockerPortAsString := string(d.DockerPort)
	                      ^

@optik-aper
Copy link
Member

Another one:

machine/driver/driver.go:222:16: Error return value of `d.createSSHKey` is not checked (errcheck)
	d.createSSHKey()
	              ^

@optik-aper
Copy link
Member

closes #24

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@happytreees happytreees merged commit af4a18e into master Jun 27, 2023
@happytreees happytreees deleted the rancher-machine branch June 27, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants