Add instances data source #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarani
added a commit
to aarani/pulumi-vultr-1
that referenced
this pull request
Nov 9, 2022
This commit switches to unofficial provider to use our pending PR[1]. [1] vultr/terraform-provider-vultr#296
aarani
added a commit
to aarani/pulumi-vultr-1
that referenced
this pull request
Nov 9, 2022
This commit switches to unofficial provider to use our pending PR[1]. [1] vultr/terraform-provider-vultr#296
aarani
added a commit
to nblockchain/terraform-provider-vultr
that referenced
this pull request
Nov 9, 2022
This new datasource allows us to receive more than one instance from the API, the usecase for this includes searching for instances in a specific region or searching for instances with a specific tag. Upstream PR: vultr#296
aarani
added a commit
to aarani/pulumi-vultr-1
that referenced
this pull request
Nov 9, 2022
This commit switches to our unofficial provider[1] to use our pending PR[2]. [1] https://github.com/nblockchain/terraform-provider-vultr/tree/4310e10a3fdf92a7896751ce183b013b416ef110 [2] vultr/terraform-provider-vultr#296
aarani
force-pushed
the
upstream-instances-datasource
branch
from
472b442
to
e05b6df
Compare
aarani
added a commit
to nblockchain/terraform-provider-vultr
that referenced
this pull request
Nov 14, 2022
This new datasource allows us to receive more than one instance from the API, the usecase for this includes searching for instances in a specific region or searching for instances with a specific tag. Upstream PR: vultr#296
optik-aper
reviewed
Dec 8, 2022
optik-aper
reviewed
Dec 8, 2022
|
Would you run this through |
|
Can you also provide an example of how you're intending this be used in a |
aarani
force-pushed
the
upstream-instances-datasource
branch
2 times, most recently
from
0ddb1bd
to
4974ec9
Compare
Unfortunately, we use and tested this data source in Pulumi (except the acceptance test which I ran) and I'm not really familiar with TF. |
Done. |
|
@aarani Apologies for the back and forth on this. If you can merge in master I'll get it out in the next release. |
This new datasource allows us to receive more than one instance from the API, the usecase for this includes searching for instances in a specific region or searching for instances with a specific tag.
aarani
force-pushed
the
upstream-instances-datasource
branch
from
4974ec9
to
32c1aa1
Compare
|
@optik-aper I rebased the branch and fixed the CI. |
|
@optik-aper ping? |
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new datasource allows us to receive more than one instance from the API, the usecase for this includes searching for instances in a specific region or searching for instances with a specific tag.
Checklist: