Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vultr-ccm component updates #120

Merged
merged 15 commits into from
Sep 29, 2022
Merged

vultr-ccm component updates #120

merged 15 commits into from
Sep 29, 2022

Conversation

vultj
Copy link
Contributor

@vultj vultj commented Sep 28, 2022

Description

Updates a lot of components to vultr-ccm:

  • Updates k8s.io/component-base et al to v0.24.6 (from v0.22.9)
  • Bumps go version from 1.17 to 1.19
  • Adds golangci-lint; including to github actions
  • Updates klog version
  • Removes github.com/pkg/errors in favor of just using fmt.Error
  • Updates golang.org/x/oauth2
  • Fixes a lot golangci-lint issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

This has been tested within adding/creating/deleting load balancers.

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@optik-aper optik-aper merged commit b3d1a0e into master Sep 29, 2022
@optik-aper optik-aper added dependecies enhancement New feature or request automation Build/release workflow related labels Sep 29, 2022
@vultj vultj deleted the CLOUD-2070 branch September 29, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Build/release workflow related enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants