Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cloudflare source in loadbalaner firewall rules #139

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

reubit
Copy link
Contributor

@reubit reubit commented Nov 25, 2022

Description

Add support for cloudflare source in loadbalaner firewall rules

Related Issues

Addresses #102

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@reubit
Copy link
Contributor Author

reubit commented Nov 26, 2022

@vultj @happytreees @ddymko Just flagging you guys for review.

Thanks! 🙂

@optik-aper optik-aper added the enhancement New feature or request label Nov 28, 2022
@optik-aper
Copy link
Member

This looks sane to me and tests work locally. @reubit If you wouldn't mind resolving the gofmt error we can merge this.

vultr/loadbalancer_test.go:95: File is not `gofmt`-ed with `-s` (gofmt)
			Name:        "lb-name",
			Namespace:   v1.NamespaceDefault,
			UID:         "lb-name",

@reubit
Copy link
Contributor Author

reubit commented Nov 29, 2022

Thanks @optik-aper. Just pushed the gofmt fix. Apologies for that!

@reubit
Copy link
Contributor Author

reubit commented Dec 7, 2022

@optik-aper **Nudge**

Just a gentle reminder to approve the workflows when you've got time.

Would be great to see this merged and included in the next VKE upgrade!

Thanks! 🙂

@optik-aper optik-aper merged commit 235119c into vultr:master Dec 7, 2022
@optik-aper optik-aper mentioned this pull request Feb 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants