Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added secret watcher logic #209

Merged
merged 7 commits into from
Sep 18, 2023
Merged

added secret watcher logic #209

merged 7 commits into from
Sep 18, 2023

Conversation

happytreees
Copy link
Contributor

Description

This PR will allow the CCM to watch and update LB secrets when they are used.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@happytreees happytreees added the enhancement New feature or request label Sep 15, 2023
@happytreees happytreees self-assigned this Sep 15, 2023
@happytreees happytreees marked this pull request as ready for review September 15, 2023 18:20
optik-aper
optik-aper approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@happytreees happytreees merged commit df5feaa into master Sep 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper approved these changes

Assignees

@happytreees happytreees

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@happytreees @optik-aper