VPC changes

[ddymko]

Description

Changing the default private network behavior over to use VPC

Tested on a VKE cluster

☁  Downloads  cat /Users/ddymko/go/src/github.com/vultr/vultr-cloud-controller-manager/docs/examples/load-balancer-https.yml
apiVersion: v1
kind: Service
metadata:
  annotations:
    service.beta.kubernetes.io/vultr-loadbalancer-protocol: "http"
#    service.beta.kubernetes.io/vultr-loadbalancer-https-ports: "443"
    # You will need to have created a TLS Secret and pass in the name as the value
#    service.beta.kubernetes.io/vultr-loadbalancer-ssl: "ssl-secret"
  name: vultr-lb-https
spec:
  type: LoadBalancer
  selector:
    app: app-name
  ports:
    - port: 80
      name: "http"
#    - port: 443
#      name: "https"

May 04 19:44:16 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:16.649156    9904 controller.go:403] Ensuring load balancer for service default/vultr-lb-https
May 04 19:44:16 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:16.649242    9904 controller.go:912] Adding finalizer to service default/vultr-lb-https
May 04 19:44:16 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:16.650588    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer"
May 04 19:44:16 vultr vultr-cloud-controller-manager[9904]: E0504 19:44:16.910489    9904 controller.go:310] error processing service default/vultr-lb-https (will retry): failed to ensure load balancer: load-balancer is not yet active - current status: pending
May 04 19:44:16 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:16.910584    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: load-balancer is not yet active - current status: pending"
May 04 19:44:21 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:21.911044    9904 controller.go:403] Ensuring load balancer for service default/vultr-lb-https
May 04 19:44:21 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:21.911327    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer"
May 04 19:44:22 vultr vultr-cloud-controller-manager[9904]: E0504 19:44:22.040069    9904 controller.go:310] error processing service default/vultr-lb-https (will retry): failed to ensure load balancer: load-balancer is not yet active - current status: pending
May 04 19:44:22 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:22.040197    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: load-balancer is not yet active - current status: pending"
May 04 19:44:32 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:32.041105    9904 controller.go:403] Ensuring load balancer for service default/vultr-lb-https
May 04 19:44:32 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:32.041347    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer"
May 04 19:44:32 vultr vultr-cloud-controller-manager[9904]: E0504 19:44:32.177482    9904 controller.go:310] error processing service default/vultr-lb-https (will retry): failed to ensure load balancer: load-balancer is not yet active - current status: pending
May 04 19:44:32 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:32.177578    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: load-balancer is not yet active - current status: pending"
May 04 19:44:52 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:52.177674    9904 controller.go:403] Ensuring load balancer for service default/vultr-lb-https
May 04 19:44:52 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:52.177881    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer"
May 04 19:44:52 vultr vultr-cloud-controller-manager[9904]: E0504 19:44:52.309455    9904 controller.go:310] error processing service default/vultr-lb-https (will retry): failed to ensure load balancer: load-balancer is not yet active - current status: pending
May 04 19:44:52 vultr vultr-cloud-controller-manager[9904]: I0504 19:44:52.309512    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: load-balancer is not yet active - current status: pending"
May 04 19:45:32 vultr vultr-cloud-controller-manager[9904]: I0504 19:45:32.310151    9904 controller.go:403] Ensuring load balancer for service default/vultr-lb-https
May 04 19:45:32 vultr vultr-cloud-controller-manager[9904]: I0504 19:45:32.310454    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer"
May 04 19:45:32 vultr vultr-cloud-controller-manager[9904]: E0504 19:45:32.443985    9904 controller.go:310] error processing service default/vultr-lb-https (will retry): failed to ensure load balancer: load-balancer is not yet active - current status: pending
May 04 19:45:32 vultr vultr-cloud-controller-manager[9904]: I0504 19:45:32.444088    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: load-balancer is not yet active - current status: pending"
May 04 19:46:52 vultr vultr-cloud-controller-manager[9904]: I0504 19:46:52.444269    9904 controller.go:403] Ensuring load balancer for service default/vultr-lb-https
May 04 19:46:52 vultr vultr-cloud-controller-manager[9904]: I0504 19:46:52.444698    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer"
May 04 19:46:52 vultr vultr-cloud-controller-manager[9904]: I0504 19:46:52.614630    9904 loadbalancers.go:184] Called UpdateLoadBalancers
May 04 19:46:53 vultr vultr-cloud-controller-manager[9904]: I0504 19:46:53.000369    9904 controller.go:953] Patching status for service default/vultr-lb-https
May 04 19:46:53 vultr vultr-cloud-controller-manager[9904]: I0504 19:46:53.000690    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Normal" reason="EnsuredLoadBalancer" message="Ensured load balancer"



May 04 19:48:43 vultr vultr-cloud-controller-manager[9904]: I0504 19:48:43.201260    9904 controller.go:403] Ensuring load balancer for service default/vultr-lb-https
May 04 19:48:43 vultr vultr-cloud-controller-manager[9904]: I0504 19:48:43.201969    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer"
May 04 19:48:43 vultr vultr-cloud-controller-manager[9904]: I0504 19:48:43.335197    9904 loadbalancers.go:184] Called UpdateLoadBalancers
</code></pre>

CLI output of LB to confirm 

<pre><code class="shell">
☁  Downloads  cat /Users/ddymko/go/src/github.com/vultr/vultr-cloud-controller-manager/docs/examples/load-balancer-https.yml
apiVersion: v1
kind: Service
metadata:
  annotations:
    service.beta.kubernetes.io/vultr-loadbalancer-protocol: "http"
    service.beta.kubernetes.io/vultr-loadbalancer-vpc: "true"
#    service.beta.kubernetes.io/vultr-loadbalancer-https-ports: "443"
    # You will need to have created a TLS Secret and pass in the name as the value
#    service.beta.kubernetes.io/vultr-loadbalancer-ssl: "ssl-secret"
  name: vultr-lb-https
spec:
  type: LoadBalancer
  selector:
    app: app-name
  ports:
    - port: 80
      name: "http"
#    - port: 443
#      name: "https"

☁  Downloads  vultr-cli lb list
ID		ab3684bc-c8ce-41e9-9b6f-949885616d57
DATE CREATED	2022-05-04T19:44:16+00:00
REGION		ewr
LABEL		a03d2aa80443546768e95665a835f668
STATUS		active
IPV4		104.156.226.17
IPV6		2001:19f0:0005:04cf:ffff:ffff:ffff:ffff
HAS SSL		false
INSTANCES	[6db4bd6f-abd6-4aff-b7a2-33575cbfa331]

HEALTH CHECKS
PROTOCOL	PORT	PATH	CHECK INTERVAL	RESPONSE TIMEOUT	UNHEALTHY THRESHOLD	HEALTHY THRESHOLD
tcp		32421		15		5			5			5

GENERIC INFO
BALANCING ALGORITHM	SSL REDIRECT	COOKIE NAME	PROXY PROTOCOL	PRIVATE NETWORK
roundrobin		false				false		5b247562-8de2-440d-b345-a2f9e19e2240

FORWARDING RULES
RULEID			FRONTEND PROTOCOL	FRONTEND PORT	BACKEND PROTOCOL	BACKEND PORT
87e2fde4dc174736	http			80		http			32421

FIREWALL RULES
RULEID	PORT	SOURCE	IP_TYPE
-	-	-
---------------------------
======================================
TOTAL	NEXT PAGE	PREV PAGE
1
☁  Downloads  vultr-cli vpc get 5b247562-8de2-440d-b345-a2f9e19e2240
ID					REGION	DESCRIPTION						V4 SUBNET	V4 SUBNET MASK	DATE CREATED
5b247562-8de2-440d-b345-a2f9e19e2240	ewr	VKE_Network_3036bd5e-c4ec-4bfa-9f37-d7411cb1344b	10.1.96.0	20		2022-05-03T19:58:30+00:00
</code></pre>


Enabling VPC and pirvatenetwork together


<pre><code class="shell">
May 04 19:55:04 vultr vultr-cloud-controller-manager[9904]: I0504 19:55:04.032516    9904 loadbalancers.go:184] Called UpdateLoadBalancers
May 04 19:55:04 vultr vultr-cloud-controller-manager[9904]: E0504 19:55:04.201240    9904 controller.go:310] error processing service default/vultr-lb-https (will retry): failed to ensure load balancer: failed to create load balancer request: can not use private_network and vpc annotations. Please use VPC as private network is deprecated
May 04 19:55:04 vultr vultr-cloud-controller-manager[9904]: I0504 19:55:04.201397    9904 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: failed to create load balancer request: can not use private_network and vpc annotations. Please use VPC as private network is deprecated"

Related Issues

Checklist:

• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you linted your code locally prior to submission?
• Have you successfully ran tests with your changes locally?